claircore: change Package.Kind type and add new values#1781
claircore: change Package.Kind type and add new values#1781
Package.Kind type and add new values#1781Conversation
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
2 times, most recently
from
fe5217b to
e8b5727
Compare
| // An "ancestry" package is used to refer to a container layer and all | ||
| // previous layers in an image. | ||
| // | ||
| // Conceptually, an "ancestry" package is a higher type that describes the | ||
| // container image rather than the contents. | ||
| PackageAncestry // ancestry |
There was a problem hiding this comment.
I'm not sure why, but this seems a bit unclear to me. Did you have some other ideas about this name? Or maybe we should explain why this value is important.
There was a problem hiding this comment.
| // An "ancestry" package is used to refer to a container layer and all | |
| // previous layers in an image. | |
| // | |
| // Conceptually, an "ancestry" package is a higher type that describes the | |
| // container image rather than the contents. | |
| PackageAncestry // ancestry | |
| // An "ancestry" package is used to refer to a container layer and all | |
| // previous layers (a layer and its ancestors) in an image. | |
| // | |
| // Conceptually, an "ancestry" package is a higher type that describes the | |
| // container image rather than the contents. | |
| PackageAncestry // ancestry |
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
2 times, most recently
from
853067b to
ccb5dd6
Compare
There was a problem hiding this comment.
How does this fit with https://github.com/quay/claircore/blob/main/toolkit/types/package_kind.go? Is that replaced with this?
There was a problem hiding this comment.
It probably needs to be updated in turn. Will do.
There was a problem hiding this comment.
This order is now different: Unknown/Binary/Source vs Unknown/Source/Binary, although it seems like the toolkit one isn't actually used anywhere, should we just delete it?
There was a problem hiding this comment.
I don't understand what you mean. If you mean different to the claircore.PackageKind, then yes but they're different types.
I think I had this in here to facilitate moving the opposite way I did (like with the cpe package). I think this should stay if only for actual API reasons. I could also have this be the type instead of a new one in claircore.
There was a problem hiding this comment.
My thought was just that it's confusing having 2 types to represent what I think is the same thing, but I get that it's annoying to not have it next to the Package type. My preference would be to remove it from the toolkit, if we believe it's being used by someone that seems like we'd want to deprecate it and encourage movement to the new type (which has different Unmarshal behaviour IIUC). I could be missing something
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
from
ccb5dd6 to
c5d4984
Compare
This was largely an automated rewrite, but does touch a lot of files. See-also: https://issues.redhat.com/browse/CLAIRDEV-85 Change-Id: I6ed030878dcccb1a5d0c437f2b480e9f0bea80fd Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
from
c5d4984 to
8a8d058
Compare
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: Icbab38c7f062c8d4e057bd8ca89ab1c26a6a6964 JJ: See-Also: CLAIRDEV-NNNN JJ: Closes: #NNNN
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: Icbab38c7f062c8d4e057bd8ca89ab1c26a6a6964
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
from
e1b61f4 to
14447f5
Compare
3 participants
This was largely an automated rewrite, but does touch a lot of files.
See-also: https://issues.redhat.com/browse/CLAIRDEV-85
Change-Id: I6ed030878dcccb1a5d0c437f2b480e9f0bea80fd
Signed-off-by: Hank Donnay hdonnay@redhat.com